Initial trace id using a bit of a hack.#1682
Draft
MikeNeilson wants to merge 5 commits intodevelopfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: goal is to get this working with just the ScopeLoggingContext, however, a bit more research is required.
The combination of slf4j and logback, while not required, does simplify the create of structured logs, also allowed for that MDC "hack" within that Filter without interfering with any remaining code.
The is a gRPC context mechanism provided by flogger but I'm still reading up. I think I'm likely to create a custom ContextDataProvider (what Flogger needs implemented) to handle mapping to the SLF4j MDC. so still using that system, just cleaner.
Additionally, since we know we have async things, we'll need to sort out how the nested contexts work on a thread pool to make sure the Trace ID passing along correctly.
Need to pivot to other work tomorrow, so likely won't get back to this until Friday or next week.