Skip to content

Initial trace id using a bit of a hack.#1682

Draft
MikeNeilson wants to merge 5 commits intodevelopfrom
feature/1666-trace-id
Draft

Initial trace id using a bit of a hack.#1682
MikeNeilson wants to merge 5 commits intodevelopfrom
feature/1666-trace-id

Conversation

@MikeNeilson
Copy link
Copy Markdown
Contributor

NOTE: goal is to get this working with just the ScopeLoggingContext, however, a bit more research is required.

The combination of slf4j and logback, while not required, does simplify the create of structured logs, also allowed for that MDC "hack" within that Filter without interfering with any remaining code.

The is a gRPC context mechanism provided by flogger but I'm still reading up. I think I'm likely to create a custom ContextDataProvider (what Flogger needs implemented) to handle mapping to the SLF4j MDC. so still using that system, just cleaner.

Additionally, since we know we have async things, we'll need to sort out how the nested contexts work on a thread pool to make sure the Trace ID passing along correctly.

Need to pivot to other work tomorrow, so likely won't get back to this until Friday or next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant